Update to django 4.2 #1918
Merged
Update to django 4.2 #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
force-pushed
the
django-42
branch
from
3c0338b to
98b048d
Compare
|
@niklasmohrin: Filtering anything like: |
niklasmohrin
approved these changes
May 8, 2023
…afe -> we can get rid of three '|safe' template filter calls
…n 'update_fields' parameter when additional fields are changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, our dev-dependency
django-stubsdoesn't support django4.2 yet. However, I don't see a problem here if CI passes, so I wouldn't wait for them.The other problematic candidate,
mozilla-django-oidc, doesn't really give any kind of "we support these versions of django" information. Their tests don't yet run with django4.2. Locally, for me, OIDC login works as expected, and django's changelog doesn't indicate any relevant changes to the authentication mechanism.Running the tests with warnings enabled currently triggers these:
> /home/evap/venv/lib/python3.8/site-packages/django/contrib/auth/views.py:142: RemovedInDjango50Warning: Log out via GET requests is deprecated and will be removed in Django 5.0. Use POST requests for logging out.
-> We currently have three tests that
self.app.get(reverse("django-auth-logout"). Simply changing these to "post" seems to fail. The logout button in the navbar currently simply is a link, not a form that will be submitted. I guess both require a bit of work.> /home/evap/venv/lib/python3.8/site-packages/django/db/models/fields/related_lookups.py:52: RemovedInDjango50Warning: Passing unsaved model instances to related filters is deprecated.
-> A few of our tests currently do this (
test_copy_contribution,test_initial_from_original,test_no_original_given,test_merge_users_changes_data_on_success. Will have to reevaluate those. It seems like this also happens on some staff views (evaluation_copy, evaluation_create, import-views)